-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support running Databricks CI_PART2 integration tests with JARs built by CI_PART1 [databricks] #11840
Merged
NvTimLiu
merged 5 commits into
NVIDIA:branch-25.02
from
NvTimLiu:databricks-ci-shared-jars
Dec 11, 2024
Merged
Support running Databricks CI_PART2 integration tests with JARs built by CI_PART1 [databricks] #11840
NvTimLiu
merged 5 commits into
NVIDIA:branch-25.02
from
NvTimLiu:databricks-ci-shared-jars
Dec 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by CI_PART1 To fix: NVIDIA#11838 The CI_PART1 job uploads the built Spark Rapids tar file to Databricks DBFS storage. The CI_PART2 job retrieves the built tar file from DBFS storage and runs integration tests against it. Then the CI_PART2 job doesn't need to duplicate the building of Spark Rapids jars; it can save about 1 hour of Databricks time. Signed-off-by: timl <[email protected]>
NvTimLiu
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008 and
gerashegalov
as code owners
December 9, 2024 08:02
NvTimLiu
changed the title
Support running Databricks CI_PART2 integration tests with JARs built by CI_PART1
Support running Databricks CI_PART2 integration tests with JARs built by CI_PART1 [databricks]
Dec 9, 2024
build |
pxLi
reviewed
Dec 9, 2024
Signed-off-by: Tim Liu <[email protected]>
pxLi
reviewed
Dec 9, 2024
…within timeout minutes Signed-off-by: Tim Liu <[email protected]>
pxLi
reviewed
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some small nits
pxLi
reviewed
Dec 10, 2024
Signed-off-by: Tim Liu <[email protected]>
Signed-off-by: Tim Liu <[email protected]>
pxLi
approved these changes
Dec 10, 2024
build |
gerashegalov
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix: #11838
The CI_PART1 job uploads the built Spark Rapids tar file to Databricks DBFS storage.
The CI_PART2 job retrieves the built tar file from DBFS storage and runs integration tests against it.
Then the CI_PART2 job doesn't need to duplicate the building of Spark Rapids jars; it can save about 1 hour of Databricks time.